Fix scroll resetting on rerun or review (#203)

canonical · Aug 8, 2024 · 7eb4eef · 7eb4eef
1 parent fcf5c52
commit 7eb4eef
Showing 1 changed file with 34 additions and 36 deletions.
diff --git a/frontend/lib/ui/artefact_page/artefact_page_body.dart b/frontend/lib/ui/artefact_page/artefact_page_body.dart
@@ -1,7 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:intersperse/intersperse.dart';
-import 'package:yaru/widgets.dart';
+import 'package:yaru/yaru.dart';
 import '../../models/artefact.dart';
 import '../../models/test_execution.dart';
 import '../../providers/filtered_test_executions.dart';
@@ -18,45 +18,43 @@ class ArtefactPageBody extends ConsumerWidget {
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     final pageUri = AppRoutes.uriFromContext(context);
-    final filteredTestExecutions =
-        ref.watch(filteredTestExecutionsProvider(pageUri));
+    final testExecutions =
+        ref.watch(filteredTestExecutionsProvider(pageUri)).value;
 
-    return filteredTestExecutions.when(
-      data: (testExecutions) => Column(
-        crossAxisAlignment: CrossAxisAlignment.start,
-        children: [
-          Row(
-            crossAxisAlignment: CrossAxisAlignment.baseline,
-            textBaseline: TextBaseline.alphabetic,
-            children: [
-              Text(
-                'Environments',
-                style: Theme.of(context).textTheme.headlineSmall,
-              ),
-              const SizedBox(width: Spacing.level4),
-              _TestExecutionsStatusSummary(testExecutions: testExecutions),
-              const Spacer(),
-              const RerunFilteredEnvironmentsButton(),
-            ],
-          ),
-          Expanded(
-            child: ListView.builder(
-              itemCount: testExecutions.length,
-              itemBuilder: (_, i) => Padding(
-                // Padding is to avoid scroll bar covering trailing buttons
-                padding: const EdgeInsets.only(right: Spacing.level3),
-                child: TestExecutionExpandable(
-                  testExecution: testExecutions[i],
-                ),
+    if (testExecutions == null) {
+      return const YaruCircularProgressIndicator();
+    }
+
+    return Column(
+      crossAxisAlignment: CrossAxisAlignment.start,
+      children: [
+        Row(
+          crossAxisAlignment: CrossAxisAlignment.baseline,
+          textBaseline: TextBaseline.alphabetic,
+          children: [
+            Text(
+              'Environments',
+              style: Theme.of(context).textTheme.headlineSmall,
+            ),
+            const SizedBox(width: Spacing.level4),
+            _TestExecutionsStatusSummary(testExecutions: testExecutions),
+            const Spacer(),
+            const RerunFilteredEnvironmentsButton(),
+          ],
+        ),
+        Expanded(
+          child: ListView.builder(
+            itemCount: testExecutions.length,
+            itemBuilder: (_, i) => Padding(
+              // Padding is to avoid scroll bar covering trailing buttons
+              padding: const EdgeInsets.only(right: Spacing.level3),
+              child: TestExecutionExpandable(
+                testExecution: testExecutions[i],
               ),
             ),
           ),
-        ],
-      ),
-      loading: () => const Center(child: YaruCircularProgressIndicator()),
-      error: (error, stackTrace) {
-        return Center(child: Text('Error: $error'));
-      },
+        ),
+      ],
     );
   }
 }