Return only latest artefacts to frontend #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omar-selo
requested changes
Jun 16, 2023
omar-selo
approved these changes
Jun 19, 2023
omar-selo
pushed a commit
that referenced
this pull request
Jun 19, 2023
* Fix the get_artefacts_by_family_name function * Return only latest artefacts to frontend * Fix style issues * Use groupby from itertools and check family name * Add test_families * Fix style issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I've updated the
v1/families/{family_name}endpoint to return only latest artefactsIt closes RTW-98
I'd tried to implement it with SQL queries, but ended up duplicating code from
get_artefacts_by_family_namemethod. So, if we needed to change the logic of retrieving latest artefacts, we would have to do it in two placesThat's why I've decided to use this method and some Python loops (unfortunately)