Fix artefact build uniqueness #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadzyah
reviewed
Jun 21, 2023
nadzyah
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves RTW-112. Specifically, it uses Postgres' NULLS NOT DISTINCT. Note that this feature has just been added to SQLAlchemy (more information can be found in the original issue, pr and release notes). But since it's just been added, alembic doesn't have a command or option for it. Therefore I wrote a plain SQL command as migration.
Also had to remove
create_artefact_buildshelper as it could occasionally break uniqueness constraint. So tests can fail randomly.