Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded artefact view #33

Merged
merged 28 commits into from
Jul 6, 2023
Merged

Expanded artefact view #33

merged 28 commits into from
Jul 6, 2023

Conversation

omar-selo
Copy link
Collaborator

@omar-selo omar-selo commented Jul 4, 2023

Implements expanded Artefact view according to Figma design. This solves Jira task RTW-85.

Notes:

  • I tried to use Yaru icons and widgets where possible (even if it may differ slightly from design)
  • I didn't implement adding test execution status count to the artefact cards themselves. If we want to do that I prefer to do it in a different PR as it adds a bit of complexity over what already is here. (will need to modify back-end endpoints)
Screencast.from.04-07-23.14.05.45.webm

@omar-selo omar-selo requested a review from nadzyah July 4, 2023 11:11
@nadzyah
Copy link
Collaborator

nadzyah commented Jul 5, 2023

Thanks for the video!
On the main screen, we don't represent all these icons since we just summarise test results there. So, on the main screen, we have only "Passed", "Error", "No Result" (the last combines "In progress", "Not started" and "Not tested")
image

In the expanded view, we have all the icons like here:
image

It also would be great to keep the order like on the design since Matias really cares about the order

@nadzyah
Copy link
Collaborator

nadzyah commented Jul 5, 2023

Is it possible to capitalise stages on the main and expanded view?

Also, it would be great if we could show "passed" stages on the expanded view with grey colour

image

@omar-selo
Copy link
Collaborator Author

Is it possible to capitalise stages on the main and expanded view?

Also, it would be great if we could show "passed" stages on the expanded view with grey colour

image

Done. Below is an updated screenshot:

Screenshot from 2023-07-05 14-53-59

@nadzyah
Copy link
Collaborator

nadzyah commented Jul 5, 2023

Done. Below is an updated screenshot:

Thanks! The only thing that bothers me is that the size of the icons seems to be kinda large. Is it the same as on the design?

frontend/lib/models/test_execution.dart Outdated Show resolved Hide resolved
frontend/lib/models/test_execution.dart Outdated Show resolved Hide resolved
@omar-selo omar-selo requested a review from nadzyah July 6, 2023 12:28
Copy link
Collaborator

@nadzyah nadzyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for answering my questions!

@omar-selo omar-selo merged commit 9b6d77c into main Jul 6, 2023
@omar-selo omar-selo deleted the artefact-dialog branch July 6, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants