Artefact links #52
Merged
Artefact links #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadzyah
reviewed
Oct 24, 2023
omar-selo
force-pushed
the
artefact-links
branch
from
64962e8
to
2df3504
Compare
nadzyah
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RTW-148
Basically, this PR is about making artefacts link-able. As right now there is no links to artefacts. This PR adds the link using the path
/family/:artefactIdSadly, this PR is much bigger than I would've liked. This is because it involved some changes and refactors both in frontend and backend. Main issue was that when I made it possible to link directly to artefacts, it no longer became possible to pass artefact data from parent widget (the stage column). Instead, the artefact dialog has to fetch artefact information on it's own. Additionally, the artefact dialog could no longer get stages information and should either fetch that too or in this PR's case just hard code the stages on the frontend. I figured there is no need to make model changes on the backend.