Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provision_type field to agent data #183

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

plars
Copy link
Collaborator

@plars plars commented Jan 9, 2024

Description

Add provision_type to the agent data that we store on the server

Resolved issues

CERTTF-277

Documentation

Nothing really, but openapi schema updated appropriately so that it will show up there for reference.

Tests

Tested locally, and unit tests adjusted

@plars plars requested a review from a team January 9, 2024 20:18
Copy link

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of questions

server/src/api/schemas.py Show resolved Hide resolved
agent/testflinger_agent/agent.py Outdated Show resolved Hide resolved
@plars plars force-pushed the provision-type-in-agent-data branch from acd257b to 4f9d356 Compare January 10, 2024 14:50
@plars plars requested a review from omar-selo January 10, 2024 14:51
Copy link

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@plars plars merged commit 83ebced into main Jan 10, 2024
5 checks passed
@plars plars deleted the provision-type-in-agent-data branch January 10, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants