device_connectors: Add default-user-data to oem_autoinstall #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinyehk
reviewed
Oct 11, 2024
There was a problem hiding this comment.
@Artur-at-work Did this change also include a default authorize_keys?
@kevinyehk No, because I'd have to add the public key into the default-user-data and it will be exposed. Will this work for you? or should we consider another approach? |
plars
requested changes
Oct 11, 2024
| @@ -44,6 +44,9 @@ def __init__(self, config, job_data): | |||
| self.config = yaml.safe_load(configfile) | |||
| with open(job_data, encoding="utf-8") as job_json: | |||
| self.job_data = json.load(job_json) | |||
| self.data_path = ( | |||
| Path(__file__).parent / "../../data/muxpi/oem_autoinstall" | |||
There was a problem hiding this comment.
I just realized that this has been using files under data/muxpi, shouldn't it organize them under data/oem_autoinstall instead? That seems like a better place for it, since they are not used by the muxpi device connector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add default-user-data file in oem_autoinstall for convenience.
When user didn't provide user-data file, it will use default one.
Resolved issues
Closes https://warthogs.atlassian.net/browse/OEX86-473
Documentation
Updated docs for oem_autoinstall
Web service API changes
N/A
Tests
https://testflinger.canonical.com/jobs/940e48fb-70df-45a3-8179-4687f352e105