Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device_connectors: zapper_iot: provide non blocking console command #384

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

kiya956
Copy link
Contributor

@kiya956 kiya956 commented Oct 19, 2024

Description

Add one more section for support non-blocking send command

Resolved issues

Prevent some commands like "reboot" stocks our tool due to it could never back to enterable state

Documentation

Web service API changes

Tests

send "reboot" command through testflinger and zapper to DUT, and make sure it would
not wait for enterable

@kiya956 kiya956 requested a review from a team as a code owner October 19, 2024 11:57
@kiya956 kiya956 force-pushed the nb-command branch 2 times, most recently from dc12b91 to 5a80ddf Compare October 21, 2024 08:50
tsunghanliu
tsunghanliu previously approved these changes Oct 21, 2024
Copy link

@tsunghanliu tsunghanliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add one more section for support non-blocking send command

Signed-off-by: ChunAn Wu <[email protected]>
Copy link
Contributor

@p-gentili p-gentili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@p-gentili p-gentili merged commit c5d982f into canonical:main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants