Review Charm for Listing #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiiwang01
approved these changes
Oct 30, 2023
|
|
||
| ``` | ||
| # Deploy ingress controller. | ||
| microk8s enable ingress:default-ssl-certificate=trino-k8s/trino-tls |
There was a problem hiding this comment.
Maybe here we can use the charm configuration instead of setting the global default ssl certificate?
Comment on lines
+33
to
+37
| web-proxy: | ||
| description: | | ||
| The address of the web proxy. To be used in combination | ||
| with google-client-id and google-client-secret values. | ||
| type: string |
There was a problem hiding this comment.
Is this the HTTP proxy to communicate with the Google Identity website? If so, Juju has some model configurations such as juju-http-proxy, juju-https-proxy, and juju-no-proxy tailored for that purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for reviewing charm code as defined in: https://discourse.charmhub.io/t/reviewing-charms/11698.