Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wizard_router add previous #433

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

WilliamMrc
Copy link
Contributor

add a previous function ro resolve #432

@WilliamMrc WilliamMrc changed the title Wizard router add previous feat: wizard_router add previous Sep 12, 2024
@WilliamMrc WilliamMrc force-pushed the wizard_router_back_improvement branch from 9d4efc3 to 902d962 Compare September 12, 2024 12:14
@WilliamMrc WilliamMrc marked this pull request as ready for review September 12, 2024 12:51
@WilliamMrc
Copy link
Contributor Author

codecov/project job is not comparing to the latest commit in main and shows changes that are not in this PR. Is there something I can do to resolve it ?

@spydon
Copy link
Contributor

spydon commented Sep 12, 2024

codecov/project job is not comparing to the latest commit in main and shows changes that are not in this PR. Is there something I can do to resolve it ?

Don't worry about that one, it's not a required one (and it doesn't work like it should atm).

@spydon
Copy link
Contributor

spydon commented Sep 18, 2024

@WilliamMrc all commits need to be signed for us to be able to merge this:
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
You can sign them retrospectively.

@WilliamMrc
Copy link
Contributor Author

hi @spydon, thanks for the feed back.
I would like your help about signature.
I have setup the gpg key and am able to sign my commits but if I rebase the branch to edit my commits, I mess up with the two merge commits you did. is there something I am missing ?

@spydon
Copy link
Contributor

spydon commented Sep 18, 2024

hi @spydon, thanks for the feed back.
I would like your help about signature.
I have setup the gpg key and am able to sign my commits but if I rebase the branch to edit my commits, I mess up with the two merge commits you did. is there something I am missing ?

You should be able to pull first and then rebase with -i and then force push, something like this:
https://hyperledger-indy.readthedocs.io/projects/sdk/en/latest/docs/contributors/signing-commits.html

@WilliamMrc WilliamMrc force-pushed the wizard_router_back_improvement branch from eef5b48 to 638be11 Compare September 18, 2024 16:01
@spydon spydon enabled auto-merge (squash) September 18, 2024 16:21
@spydon spydon force-pushed the wizard_router_back_improvement branch from e7daa83 to 0ae2eeb Compare September 18, 2024 16:43
@spydon spydon merged commit 488da86 into canonical:main Sep 18, 2024
10 of 11 checks passed
@spydon
Copy link
Contributor

spydon commented Sep 19, 2024

@WilliamMrc this feature is now included in wizard_router v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wizard_router : back function does not load previous route in routes if not already loaded in state.
2 participants