Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Album support #106
Album support #106
Changes from 8 commits
06775da
affdbf0
ccbb834
865fed6
65b8b79
c021f80
3b2e47f
73cccba
3e314dd
db3077a
70f33d8
67b14e6
7210731
4a986ee
7d91558
dc8b12e
eb46e17
5f72865
be70f2f
9da649e
068f0ad
2f42437
2610407
8be4513
e14aa75
9d81f7f
33fcdf1
f61793d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Fix typo in localization key:
album_tame_field_title
should bealbum_name_field_title
The localization key
album_tame_field_title
appears to be a typo. While it's defined in the localization file and used consistently, the word "tame" doesn't make semantic sense in this context. The field is clearly meant for the album name, so the key should follow the conventional naming pattern and bealbum_name_field_title
.app/lib/ui/flow/albums/add/add_album_screen.dart:99
: Update the key toalbum_name_field_title
app/assets/locales/app_en.arb
: Update the key fromalbum_tame_field_title
toalbum_name_field_title
🔗 Analysis chain
Double-check localization key.
The key
album_tame_field_title
might be a typo or mistranslation. Verify that you intended "album_name_field_title" or a similar phrase to avoid confusion in your localization strings.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 1056