Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADVAPP-1131]: When creating a campaign task due dates are being automatically added even if not populated when configuring the journey step #1248

Merged
merged 2 commits into from
Jan 21, 2025
Merged

[ADVAPP-1131]: When creating a campaign task due dates are being automatically added even if not populated when configuring the journey step #1248

merged 2 commits into from
Jan 21, 2025

Conversation

jayushi-canyon
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

When creating a campaign task, due dates are being automatically added even if not populated when configuring the journey step

Any deployment steps required?

No

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

No

Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

@jayushi-canyon jayushi-canyon added the Change Type | Bug Fix Something isn't working label Jan 16, 2025
@jayushi-canyon jayushi-canyon marked this pull request as ready for review January 16, 2025 12:35
@jayushi-canyon jayushi-canyon requested a review from a team as a code owner January 16, 2025 12:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

@jayushi-canyon
Copy link
Contributor Author

@Orrison
Along with reported issue when testing I found 2 more minor issues which I have resolved in this branch itself

  1. In Task, when assigned_to field is kept empty in step 2 then in review step (step 3) it gives error.
  2. In few blocks executed_at field are not showing value because of wrong field name, which I have solved as well in this PR.

Let me know your thoughts on the same.

@Orrison Orrison added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit bf8ce97 Jan 21, 2025
7 checks passed
@Orrison Orrison deleted the feature/ADVAPP-1131 branch January 21, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orrison Orrison Orrison approved these changes

Assignees
No one assigned
Labels
Change Type | Bug Fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayushi-canyon @Orrison