Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace hour input with html native input type="time" #447

Merged
merged 7 commits into from
Aug 1, 2024

Conversation

myracodes
Copy link
Contributor

@myracodes myracodes commented Aug 1, 2024

🎩 What? Why?

Un bug sur l'input type heure a été repéré sur une branche de platform.
Plutôt que de le corriger et maintenir notre custom input type="dateHour", on met à jour pour utiliser le composant html natif <input type="time" />

📌 Related Issues

#446

📋 Technical Specification

  • remplacer l'input custom fait avec un ReactSelect par un input type="time" natif
  • ajouter ce composant à la story "erreur" (il manquait)

🎨 Chromatic links

Chromatic PR
Storybook

📸 Screenshots

AVANT :
Screenshot 2024-08-01 at 12 02 30

Screenshot 2024-08-01 at 12 03 34

APRES :
Screenshot 2024-08-01 at 12 02 57

Screenshot 2024-08-01 at 12 03 11

@myracodes myracodes self-assigned this Aug 1, 2024
@myracodes myracodes requested a review from a team as a code owner August 1, 2024 10:03
@myracodes myracodes marked this pull request as draft August 1, 2024 10:04
@myracodes myracodes marked this pull request as ready for review August 1, 2024 10:05
src/components/form/hour/HourInput.tsx Outdated Show resolved Hide resolved
src/components/form/hour/HourInput.tsx Outdated Show resolved Hide resolved
src/components/form/hour/HourInput.tsx Outdated Show resolved Hide resolved
@myracodes myracodes merged commit 0b4a640 into master Aug 1, 2024
6 of 7 checks passed
@myracodes myracodes deleted the 446-refactor-hour-input branch August 1, 2024 13:10
@myracodes myracodes mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants