Node 18 compatibility

cap-js-community · Jan 29, 2024 · ac3d6bd · ac3d6bd
1 parent b7a15b9
commit ac3d6bd
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -126,8 +126,8 @@ Default protocol path is `/ws` and can be overwritten via `cds.env.protocols.web
 
 The CDS websocket server supports the following two websocket implementations:
 
-- [WebSocket Standard](https://developer.mozilla.org/en-US/docs/Web/API/WebSockets_API) (via Node.js [ws](https://www.npmjs.com/package/ws) package): `cds.websocket: "ws"` **(default)**
-- [Socket.IO](https://socket.io): `cds.websocket: "socket.io"`
+- [WebSocket Standard](https://developer.mozilla.org/en-US/docs/Web/API/WebSockets_API) (via Node.js [ws](https://www.npmjs.com/package/ws) package): `cds.websocket.kind: "ws"` **(default)**
+- [Socket.IO](https://socket.io): `cds.websocket.kind: "socket.io"`
 
 The server implementation abstracts from the concrete websocket implementation. The websocket client still needs to be implemented websocket implementation specific.
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/_env/util/ws.js b/test/_env/util/ws.js
@@ -35,7 +35,9 @@ async function emitEvent(socket, event, data) {
         event,
         data,
       }),
-      resolve,
+      (result) => {
+        resolve(result || null);
+      },
     );
   });
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -35,7 +35,9 @@ async function emitEvent(socket, event, data) { @@
             event,
             data,
           }),
-          resolve,
+          (result) => {
+            resolve(result || null);
+          },
         );
       });
     }
@@ Expand Down @@