Limiting file size #105
Open
Limiting file size #105
+60
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muskansethi1
reviewed
Oct 8, 2024
rectified the test file size
CHANGELOG.md
Outdated
| @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file. | |||
| This project adheres to [Semantic Versioning](http://semver.org/). | |||
| The format is based on [Keep a Changelog](http://keepachangelog.com/). | |||
|
|
|||
| ## Version 1.1.9 | |||
There was a problem hiding this comment.
Changelog has to be added in 1.1.8 version itself
CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
|
|
||
| - Size validation check for uploaded attachments. |
There was a problem hiding this comment.
Added limit for file size ....
lib/plugin.js
Outdated
| const scanEnabled = cds.env.requires?.attachments?.scan ?? true | ||
| if(scanEnabled && status !== 'Clean') { | ||
| req.reject(403, 'Unable to download the attachment as scan status is not clean.'); | ||
| const status = await AttachmentsSrv.getStatus(req.target, { |
There was a problem hiding this comment.
you can remove the code formatting
lib/plugin.js
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| async function readAttachment([attachment], req) { | ||
| if (!req?.req?.url?.endsWith("/content") || !attachment || attachment?.content) return; | ||
| let keys = { ID : req.req.url.match(attachmentIDRegex)[1]}; | ||
| if ( |
|
You can edit the script in package.json - |
muskansethi1
approved these changes
Oct 25, 2024
|
Changes in CHANGELOG.md with mention of UI5 version compatibilty. Tested in local and hybrid mode. |
jeevitha011
reviewed
Dec 9, 2024
lib/plugin.js
Outdated
| @@ -6,7 +6,7 @@ const attachmentIDRegex = /\/\w+\(.*ID=([0-9a-fA-F-]{36})/; | |||
|
|
|||
| cds.on("loaded", function unfoldModel(csn) { | |||
| if (!("Attachments" in csn.definitions)) return; | |||
| const csnCopy = structuredClone(csn) | |||
| const csnCopy = structuredClone(csn); | |||
There was a problem hiding this comment.
Can you remove all the formatting changes in this file, as these lines are out of scope for this specific task.
jeevitha011
approved these changes
Dec 9, 2024
|
Formatted by tallying from main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the upload size of an attachment in the attachment plugin. Currently the maximum size size of data that can be scanned by the Malware Scanning Service on BTP is 400MB. So we would limit the file upload size to 400 MB.
Handling PUT request with 'before' handler to fetch the content length of the uploaded attachment in plugin.js.
Impose validation checks for size limit and rejecting the request which are above size limit.
Currently cannot access the UI part but validation checks are both imposed for hybrid and local mode.