Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requirements to readme #23

Merged
merged 2 commits into from
Aug 10, 2023
Merged

add requirements to readme #23

merged 2 commits into from
Aug 10, 2023

Conversation

sjvans
Copy link
Contributor

@sjvans sjvans commented Aug 10, 2023

No description provided.

@sjvans sjvans requested a review from chgeo August 10, 2023 08:54
README.md Outdated Show resolved Hide resolved
Co-authored-by: Christian Georgi <[email protected]>
@sjvans
Copy link
Contributor Author

sjvans commented Aug 10, 2023

@chgeo should we reuse this section in the other cap-js repos as suggested by @I827833?

@sjvans sjvans marked this pull request as ready for review August 10, 2023 10:25
@sjvans
Copy link
Contributor Author

sjvans commented Aug 10, 2023

@chgeo should we reuse this section in the other cap-js repos as suggested by @I827833?

-> cap-js/cds-dbs#163

@chgeo
Copy link
Contributor

chgeo commented Aug 10, 2023

Reusing, i.e. linking to one sentence is bit of an overkill imho. Just copy it. Often it would need to be adjusted anyways.

@sjvans
Copy link
Contributor Author

sjvans commented Aug 10, 2023

Reusing, i.e. linking to one sentence is bit of an overkill imho. Just copy it. Often it would need to be adjusted anyways.

of course copy it. 😄 just wanted to know if you're ok with it.

@sjvans sjvans merged commit 49bb894 into main Aug 10, 2023
3 checks passed
@sjvans sjvans deleted the requirements branch August 10, 2023 16:18
@sjvans sjvans mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants