chore: make use of optional catch binding (#683)

Optional catch binding is a feature introduced in ECMAScript 2019 (ES10)
that allows you to use catch clauses in try/catch statements without
specifying an error variable

db-service/lib/SQLService.js

@@ -115,7 +115,7 @@ class SQLService extends DatabaseService {
    */
   async onSELECT({ query, data }) {
     if (!query.target) {
-      try { this.infer(query) } catch (e) { /**/ }
+      try { this.infer(query) } catch { /**/ }
     }
     if (query.target && !query.target._unresolved) {
       // Will return multiple rows with objects inside

hana/lib/HANAService.js

@@ -117,7 +117,7 @@ class HANAService extends SQLService {
     const { query, data } = req
 
     if (!query.target) {
-      try { this.infer(query) } catch (e) { /**/ }
+      try { this.infer(query) } catch { /**/ }
     }
     if (!query.target || query.target._unresolved) {
       return super.onSELECT(req)

hana/lib/drivers/index.js

@@ -14,14 +14,14 @@ Object.defineProperties(module.exports, {
         // Have a bias to hdb as the default driver
         if (dependencies.hdb) return module.exports.hdb
         if (dependencies['@sap/hana-client']) return module.exports['hana-client']
-      } catch (e) {
+      } catch {
         console.trace(`WARNING! Unable to require the project's package.json at "${cds.root + '/package.json'}". Please check your project setup.`)
       }
 
       // When no driver is installed still try to load any of the drivers
       try {
         return module.exports.hdb
-      } catch (e) {
+      } catch {
         return module.exports['hana-client']
       }
     },

postgres/lib/PostgresService.js

@@ -566,7 +566,7 @@ GROUP BY k
         GRANT "${creds.usergroup}" TO "${creds.user}" WITH ADMIN OPTION;
       `)
       await this.exec(`CREATE DATABASE "${creds.database}" OWNER="${creds.user}" TEMPLATE=template0`)
-    } catch (e) {
+    } catch {
       // Failed to reset database
     } finally {
       await this.dbc.end()

postgres/test/beershop/srv/beershop-service.js

@@ -5,7 +5,7 @@ module.exports = srv => {
     let db
     try {
       db = await cds.connect.to('db')
-    } catch (err) {
+    } catch {
       db = cds.db
     }
     await cds.deploy('./srv/', {}).to(db)

sqlite/test/general/stream.compat.test.js

@@ -170,7 +170,7 @@ describe('streaming', () => {
 
         try {
           expect(changes).toEqual(2)
-        } catch (e) {
+        } catch {
           // @sap/hana-client does not allow for returning the number of affected rows
         }
 
@@ -218,7 +218,7 @@ describe('streaming', () => {
         const changes = await INSERT.into(Images).entries(stream)
         try {
           expect(changes).toEqual(count)
-        } catch (e) {
+        } catch {
           // @sap/hana-client does not allow for returning the number of affected rows
         }
       })

sqlite/test/general/stream.test.js

@@ -234,7 +234,7 @@ describe('streaming', () => {
 
         try {
           expect(changes).toEqual(2)
-        } catch (e) {
+        } catch {
           // @sap/hana-client does not allow for returning the number of affected rows
         }
 
@@ -277,7 +277,7 @@ describe('streaming', () => {
         const changes = await INSERT(stream).into(Images)
         try {
           expect(changes | 0).toEqual(count)
-        } catch (e) {
+        } catch {
           // @sap/hana-client does not allow for returning the number of affected rows
         }
       }))

test/cds.js

@@ -58,7 +58,7 @@ cds.test = Object.setPrototypeOf(function () {
       const serviceDefinitionPath = testSource + 'test/service'
       cds.env.requires.db = require(serviceDefinitionPath)
       require(testSource + 'cds-plugin')
-    } catch (e) {
+    } catch {
       // Default to sqlite for packages without their own service
       cds.env.requires.db = require('@cap-js/sqlite/test/service')
     }