test: Run Postgres tests with version 14 15 16 #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
patricebender,
gregorwolf,
sebastianesch,
vobu,
danjoa,
johannes-vogel and
stewsk
as code owners
|
It seems some Postgres only tests are flaky like admin-service.test.js (example) |
| @@ -3,7 +3,7 @@ version: '3.1' | |||
|
|
|||
| services: | |||
| db: | |||
| image: postgres:16-alpine | |||
| image: postgres:${VER}-alpine | |||
There was a problem hiding this comment.
That would always require you to set the env variable locally as well. I'd prefer a solution that works locally ootb.
There was a problem hiding this comment.
I have adjusted npm run start to always include the latest as default value.
There was a problem hiding this comment.
sounds good to me. Could you please check the failing pipeline as well?
|
In general, I don't think it's required to run all versions on each PR. A cron job doing this nightly is imo sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by #364