Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Run Postgres tests with version 14 15 16 #367

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: Run Postgres tests with version 14 15 16 #367

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fedcaf6
Test postgres 14 15 16
BobdenOs Dec 1, 2023
e77fd9d
Switch to cron job
BobdenOs Dec 1, 2023
5126881
Merge branch 'main' into issues/364
patricebender Dec 14, 2023
e29bb28
Merge branch 'main' into issues/364
patricebender Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions postgres/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@
"npm": ">=8"
},
"scripts": {
"test": "npm start && jest --silent",
"start": "docker-compose -f pg-stack.yml up -d"
"test": "VER=14 npm run _test && VER=15 npm run _test && VER=16 npm run _test",
"_test": "npm start && jest --silent",
"start": "docker-compose -f pg-stack.yml up --force-recreate -d"
},
"dependencies": {
"@cap-js/db-service": "^1.3.1",
Expand Down
2 changes: 1 addition & 1 deletion postgres/pg-stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: '3.1'

services:
db:
image: postgres:16-alpine
image: postgres:${VER}-alpine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would always require you to set the env variable locally as well. I'd prefer a solution that works locally ootb.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have adjusted npm run start to always include the latest as default value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me. Could you please check the failing pipeline as well?

restart: always
environment:
POSTGRES_PASSWORD: postgres
Expand Down
Loading