fix: Improved behavioral consistency between the database services #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
patricebender,
gregorwolf,
sebastianesch,
vobu,
danjoa,
johannes-vogel and
stewsk
as code owners
…cds-dbs into clean-dependencies
…into clean-dependencies
BobdenOs
changed the title
BobdenOs
pushed a commit
that referenced
this pull request
Oct 10, 2024
Merged
BobdenOs
added a commit
that referenced
this pull request
Oct 10, 2024
) This PR contains a few fixes that where required to make the new compliance tests to pass: - Decimal precision behavior is aligned between the databases when defined - `@cap-js/hana` now properly supports scalar `SELECT` queries in the columns The goal of this PR is to remove as much dependencies as possible now that `cds@8` provides the `cds-test` command. - Removing `jest` by switching to `cds-test` - Removed `jest.config.js` files - Removing `chai` by switching to `cds-test` - Adjust all tests to fit with the `cds-test` `expect` pattern - Removing `HANA` test action - Move `HXE` Github action steps into a reuse file - Added a lock for `HANA` database creation - Added a fallback for `Postgres` during database creation - Removed compliance import tests - Added symbolic link to the compliance test folder --------- Co-authored-by: Daniel Hutzel <[email protected]> Co-authored-by: Johannes Vogel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few fixes that where required to make the new compliance tests to pass:
@cap-js/hananow properly supports scalarSELECTqueries in the columnsThe goal of this PR is to remove as much dependencies as possible now that
cds@8provides thecds-testcommand.jestby switching tocds-testjest.config.jsfileschaiby switching tocds-testcds-testexpectpatternHANAtest actionHXEGithub action steps into a reuse fileHANAdatabase creationPostgresduring database creation