fix(deep): prevent false unique constraint errors and combine delete queries #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Kunz
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs,
patricebender and
sjvans
as code owners
BobdenOs
reviewed
Aug 22, 2024
David-Kunz
changed the title
patricebender
approved these changes
Sep 3, 2024
db-service/lib/deep-queries.js
Outdated
| @@ -2,6 +2,8 @@ const cds = require('@sap/cds') | |||
| const { _target_name4 } = require('./SQLService') | |||
| const InsertResult = require('../lib/InsertResults') | |||
There was a problem hiding this comment.
Suggested change
| const InsertResult = require('../lib/InsertResults') |
Merged
johannes-vogel
pushed a commit
that referenced
this pull request
Sep 4, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.12.1</summary> ## [1.12.1](db-service-v1.12.0...db-service-v1.12.1) (2024-09-03) ### Fixed * deep `groupby` expand queries ([#768](#768)) ([5423cf3](5423cf3)) * **deep:** prevent false unique constraint errors and combine delete queries ([#781](#781)) ([01de95f](01de95f)) * **logging:** from changes in @sap/cds ([#791](#791)) ([1e8bf06](1e8bf06)) * prepend aliases to refs within function args in on conditions ([#795](#795)) ([9b34314](9b34314)), closes [#779](#779) * prevent $search queries from throwing ([#772](#772)) ([cdf4d37](cdf4d37)) </details> <details><summary>hana: 1.2.0</summary> ## [1.2.0](hana-v1.1.1...hana-v1.2.0) (2024-09-03) ### Added * wrap client if @dynatrace/oneagent-sdk is present ([#777](#777)) ([147b88e](147b88e)) ### Fixed * Add `{list:[{val}]}` json function support ([#784](#784)) ([ce5f856](ce5f856)) * Allow applications to configure `acquireTimeoutMillis` ([#796](#796)) ([abac818](abac818)) * deep `groupby` expand queries ([#768](#768)) ([5423cf3](5423cf3)) * Enforce `LargeStrings` to be `Strings` for `sql_simple_queries=1` ([#774](#774)) ([c38a9e6](c38a9e6)) * wrong falsy checks for vals in list optimization ([#797](#797)) ([e818da8](e818da8)) ### Changed * requires @sap/cds >= 8.2 ([#789](#789)) ([3bbde18](3bbde18)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
existing: Foo( ID: 1, name: "foo" )
DELETE: Foo( ID: 3, name: "bar" ) <-- can never fail
UPDATE: Foo( ID: 1, name: "bar" ) <-- can prevent fail
INSERT: Foo( ID: 2, name: "foo" )
possible test: