Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add tests for computed elements #787

Merged
merged 4 commits into from
Sep 2, 2024
Merged

test: Add tests for computed elements #787

merged 4 commits into from
Sep 2, 2024
+56 −1

Conversation

BobdenOs
Copy link
Contributor

No description provided.

@johannes-vogel johannes-vogel added the next release pr to be checked for next release label Aug 28, 2024
@johannes-vogel
Copy link
Contributor

Is there also a runtime query that tests this?

@BobdenOs
Copy link
Contributor Author

Is there also a runtime query that tests this?

All the objects defined in the module.exports are being inserted into the table definitions. Then afterwards they are being read and checked for correctness. Where all properties starting with = are used as expectation when the inserted property is different then the returned result. (test, example)

@johannes-vogel johannes-vogel enabled auto-merge (squash) September 2, 2024 07:56
@johannes-vogel johannes-vogel merged commit f70abcb into main Sep 2, 2024
4 checks passed
@johannes-vogel johannes-vogel deleted the fix/insert-calculated-column branch September 2, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricebender patricebender patricebender approved these changes

@danjoa danjoa Awaiting requested review from danjoa danjoa is a code owner

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel johannes-vogel is a code owner

@stewsk stewsk Awaiting requested review from stewsk stewsk is a code owner

@sjvans sjvans Awaiting requested review from sjvans sjvans is a code owner

Assignees
No one assigned
Labels
next release pr to be checked for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobdenOs @johannes-vogel @patricebender