-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dont use virtual key for UPDATE … where (<key>) in <subquery>
#800
Merged
Commits on Sep 7, 2024
-
fix: dont use virtual key elements for
UPDATE
where conditionFor a draft enabled model: ``` namespace my; entity Books { key ID : Integer; title : String; stock : Integer; author : Association to Authors; } entity Authors { key ID : Integer; name : String; alive : Boolean; } service CatalogService { @odata.draft.enabled @readonly entity Books as projection on my.Books; @readonly entity Authors as projection on my.Authors; } ``` `my.Books` will have a field: ``` "IsActiveEntity": { "type": "cds.Boolean", "key": true, "default": { "val": true }, "@UI.Hidden": true }, ``` which is marked as virtual by the lean draft implementation. This virtual key must not be part of the primary key matching which is done for a path expression in a `UPDATE.where`: https://github.com/cap-js/cds-dbs/blob/982b8b796da4b577c5641039d2036816209c0437/db-service/test/cqn4sql/UPDATE.test.js#L73-L97 TODO: - [] test this
Configuration menu - View commit details
-
Copy full SHA for 233af38 - Browse repository at this point
Copy the full SHA 233af38View commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 893a863 - Browse repository at this point
Copy the full SHA 893a863View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1051200 - Browse repository at this point
Copy the full SHA 1051200View commit details
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0c193c4 - Browse repository at this point
Copy the full SHA 0c193c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7cec64 - Browse repository at this point
Copy the full SHA b7cec64View commit details -
Configuration menu - View commit details
-
Copy full SHA for a756755 - Browse repository at this point
Copy the full SHA a756755View commit details -
Configuration menu - View commit details
-
Copy full SHA for d46bce8 - Browse repository at this point
Copy the full SHA d46bce8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2564fb7 - Browse repository at this point
Copy the full SHA 2564fb7View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 300296f - Browse repository at this point
Copy the full SHA 300296fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84eb84c - Browse repository at this point
Copy the full SHA 84eb84cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.