Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: boolean for sql_simple_queries #886

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

larslutz96
Copy link
Contributor

@larslutz96 larslutz96 commented Nov 8, 2024

For sql_simple_queries=2 elements of Boolean type are returned as strings due to the output converter. To correct this, we disable the boolean output converter for this feature flag.

@patricebender
Copy link
Member

just out of curiosity: what does sql_simple_queries=2 do? why is the value of this feature flag 2?

@johannes-vogel
Copy link
Contributor

just out of curiosity: what does sql_simple_queries=2 do? why is the value of this feature flag 2?

sql_simple_queries>0 allows to use SQL statements without JSON functions if possible.
sql_simple_queries=1 uses JSON functions for expands and boolean conversion
sql_simple_queries=2 uses JSON functions for expands

@johannes-vogel johannes-vogel merged commit d8139fa into main Nov 13, 2024
3 checks passed
@johannes-vogel johannes-vogel deleted the fix-boolean-simple-queries branch November 13, 2024 09:52
@cap-bots cap-bots mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants