feat: support for cds.Map #889
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelBrucksch
changed the title
|
I think for this change to work we need at least compiler v5.4.0 |
|
I've merged main branch now which uses already newest cds+compiler versions |
johannes-vogel
changed the title
|
@BobdenOs I've tried to fix the remaining HANA failure but I think we need to have a look together. |
BobdenOs
approved these changes
Dec 18, 2024
|
double check conversion of map type with simple queries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Map type also has
elements, we get into thatifand then it is ignored. So I added a check, to pass through map type, so it is handled like a normal ref.