Determine optional action parameters from CSN's notNull
#332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the use of `@Core.OptionalParameter` for optional parameters (which was an intermediate solution anyways) by evaluating CSN's `notNull` property. This is in line with the decision in the CDS spec meeting and with what RFC importer now generates. Note that this formally inverses the default for optional parameters: - They are all optional by default, which is how the runtime treats it. - Mandatory parameters now have to be marked with `notNull` (or `not null` in CDL).
chgeo
changed the title
notNullnotNull
|
related: #315 |
Has this property been present all along or does it require a certain version of |
Has been there for a long time. |
chgeo
added a commit
that referenced
this pull request
Oct 16, 2024
`array of` needs to be supported as well:
```cds
function check(
param_2: Array of String not null
) returns ...
```
Explaining comment is
[here](#332 (comment)).
---------
Co-authored-by: Christian Georgi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of
@Core.OptionalParameterfor optional parameters (which was an intermediate solution anyways) by evaluating CSN'snotNullproperty. This is in line with the decision in the CDS spec meeting and with what RFC importer now generates.Note that this formally inverses the default for optional parameters:
notNull(ornot nullin CDL).