Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose outbox features #12

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Conversation

Kkoile
Copy link
Contributor

@Kkoile Kkoile commented Jan 5, 2024

cds.outboxed and cds.unboxed were not exposed

@daogrady
Copy link
Contributor

daogrady commented Jan 8, 2024

Hi Nils,

thanks for this addition as well! I was looking for these two in CAPire but was only able to find them in the release notes so far. @johannes-vogel are the two signatures part of the API yet?

Best,
Daniel

@daogrady
Copy link
Contributor

Hi Nils,

@johannes-vogel informed me that this addition is correct and that the relevant change to CAPire is still pending, but on its way. If you could please appease the one open linter error we will gladly merge your PR.

Best,
Daniel

@Kkoile
Copy link
Contributor Author

Kkoile commented Jan 22, 2024

Sure! I updated the pull request

@daogrady daogrady self-requested a review January 22, 2024 15:03
Copy link
Contributor

@daogrady daogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Cheers!

@daogrady daogrady merged commit 9e75c33 into cap-js:main Jan 22, 2024
4 checks passed
daogrady added a commit that referenced this pull request Jan 22, 2024
daogrady added a commit that referenced this pull request Jan 22, 2024
* Reorder overloads to give plural precedence over singular

* Sneak in missing changelog for #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants