Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @types/node from 22.2.0 to 22.5.4 #222

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 5, 2024

Bumps @types/node from 22.2.0 to 22.5.4.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 5, 2024
@dependabot dependabot bot requested a review from daogrady as a code owner September 5, 2024 02:52
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/types/node-22.5.4 branch 2 times, most recently from 155c090 to 11a3d0e Compare September 11, 2024 11:49
@chgeo chgeo enabled auto-merge (squash) September 11, 2024 11:49
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/types/node-22.5.4 branch 3 times, most recently from 4aadb49 to 0ab99d0 Compare September 11, 2024 11:55
@chgeo
Copy link
Contributor

chgeo commented Sep 11, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/types/node-22.5.4 branch from 0ab99d0 to 3c2f1e2 Compare September 11, 2024 12:24
@chgeo
Copy link
Contributor

chgeo commented Sep 11, 2024

@daogrady this turns out to be a bug in our rollup-patch.js script where the import replacements are not working.

Since this 22.5.4 version, types seem to have changed such that this import gets emitted in the rollup file:

import { ReadableStream as ReadableStream_2 } from 'node:stream/web';

and we don't seem to be prepared to replace the { ... as ReadableStream_2 } alias in the usages:

where(filter: any): ReadableStream_2

The expected result is

where(filter: any): import('node:stream/web').ReadableStream

Can you fix the script?

@daogrady
Copy link
Contributor

I see. Will look into it, sorry for the inconvenience and thanks for investigating the root cause.

@chgeo
Copy link
Contributor

chgeo commented Sep 12, 2024

@dependabot recreate

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.2.0 to 22.5.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/types/node-22.5.4 branch from 3c2f1e2 to 3de5c05 Compare September 12, 2024 06:58
@chgeo chgeo merged commit 6842e74 into main Sep 12, 2024
6 checks passed
@chgeo chgeo deleted the dependabot/npm_and_yarn/types/node-22.5.4 branch September 12, 2024 06:58
@chgeo
Copy link
Contributor

chgeo commented Sep 12, 2024

Works. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants