Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds correct type inference when using .columns in SELECT #298

Merged
merged 5 commits into from
Nov 11, 2024
Merged

fix: adds correct type inference when using .columns in SELECT #298

merged 5 commits into from
Nov 11, 2024

Conversation

stockbal
Copy link
Contributor

@stockbal stockbal commented Oct 26, 2024 •
edited
Loading

The rework in ql.d.ts resulted in missing/incorrect type inference when using .columns in SELECT queries.

image

As a result the result of such a query is no longer typed as expected but has an any type instead

Closes #322

@daogrady daogrady self-requested a review November 11, 2024 07:48
daogrady
daogrady approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@daogrady daogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! :)

@daogrady daogrady enabled auto-merge (squash) November 11, 2024 07:48
@daogrady daogrady merged commit e431159 into cap-js:main Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daogrady daogrady daogrady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Missing Type Inference when using .columns in SELECT queries
2 participants
@stockbal @daogrady