Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow calling service.read with ref #361

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Allow calling service.read with ref #361

merged 1 commit into from
Dec 4, 2024
+8 −1

Conversation

daogrady
Copy link
Contributor

@daogrady daogrady commented Dec 3, 2024

Fixes #360

@daogrady daogrady requested a review from Akatuoro December 3, 2024 22:05
@daogrady daogrady enabled auto-merge (squash) December 3, 2024 22:05
Akatuoro
Akatuoro approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Akatuoro Akatuoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in sflight -> works

@daogrady daogrady merged commit 9ebe0cd into main Dec 4, 2024
8 checks passed
@daogrady daogrady deleted the feat/service.read-ref branch December 4, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akatuoro Akatuoro Akatuoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] type error for this.read(req.subject)
2 participants
@daogrady @Akatuoro