Fix Missing exports & failing tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chgeo
changed the title
chgeo
reviewed
Dec 8, 2023
|
Thank you both for casting a keen eye on the changes! I think we are in good shape for having everything ready for next week's release. I will tackle the remaining comments on Monday. Have a nice weekend! |
daogrady
commented
Dec 11, 2023
chgeo
approved these changes
Dec 11, 2023
|
Let's merge this and refine from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a
minormedium-sized rework to fix the failing tests.Note that, as mentioned in today's meeting, declarations in ambient contexts are always exported. I have instead marked definitions that are not supposed to be used with
@private. That doesn't change their visibility, but it conveys our intention.