add definition for cds.env.features
#5
Conversation
apis/env.d.ts
Outdated
| */ | ||
| serve_on_root: boolean, | ||
|
|
||
| with_mocks: boolean, |
There was a problem hiding this comment.
This is only mentioned in an archive article on CAPire. Still should we link it for completeness sake?
https://cap.cloud.sap/docs/releases/archive/2021/dec21#developer-experience
apis/env.d.ts
Outdated
| /** | ||
| * @private | ||
| */ | ||
| hybrid_instance_manager: boolean, |
There was a problem hiding this comment.
apis/env.d.ts
Outdated
| /** | ||
| * @private | ||
| */ | ||
| keys_in_data_compat: boolean, |
There was a problem hiding this comment.
apis/env.d.ts
Outdated
| /** | ||
| * @private | ||
| */ | ||
| skip_unused: false | "all", |
There was a problem hiding this comment.
apis/env.d.ts
Outdated
| /** | ||
| * @private | ||
| */ | ||
| with_parameters: boolean |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you for adding in these types! Looks pretty clean to me -- see my few nits and suggestions, but they are no blockers imo.
Regarding the missing documentation links: this may actually be a wakeup call that CAPire is incomplete in this regard. I don't think users should have to refer to change logs for reference. So this is probably more a gap in our documentation. @johannes-vogel what do you think?
This was a process issue in the cds runtime that was addressed recently. Records of internal CDS changes within the changelogs were maintained in the past. This inadvertently led to internal feature toggles being documented. For that reason, internal change logs are now kept separate from the public ones. The perception is that a feature toggle can be utilized if documented in CAPire without any disclaimer. Otherwise, why document the feature toggle in the first place? |
|
@johannes-vogel is working in a PR to close this documentation gap. |
|
Sorry for the late reply. Johannes and I discussed this PR earlier and came to the conclusion, that we want to at least postpone this PR until all features are officially documented. So I changed it to draft for now. |
No description provided.