Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cds^8.2] Event Broker: S/4HANA Cloud to CAP #1198

Merged
merged 53 commits into from
Sep 25, 2024
Merged

Conversation

sjvans
Copy link
Contributor

@sjvans sjvans commented Aug 16, 2024

No description provided.

@sjvans sjvans changed the title [wip] SAP Event Broker [wip] Event Broker: S/4HANA Cloud to CAP Aug 16, 2024
@sjvans sjvans changed the title [wip] Event Broker: S/4HANA Cloud to CAP [cds^8.2] Event Broker: S/4HANA Cloud to CAP Aug 20, 2024
@sjvans sjvans marked this pull request as ready for review August 20, 2024 23:23
@sjvans sjvans requested a review from smahati as a code owner August 20, 2024 23:23
Comment on lines 39 to 41
// TODO: the guide is not yet published!!!

Follow guide _SAP Event Broker Service Guide_ → _Integration Scenarios_ → [CAP Application as a Subscriber](https://help.sap.com/docs/event-broker/event-broker-draft-service/integration-example-using-cap-application?state=DRAFT) to prepare your SAP BTP account for event consumption.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: the guide is not yet published!!!
Follow guide _SAP Event Broker Service Guide_ → _Integration Scenarios_ → [CAP Application as a Subscriber](https://help.sap.com/docs/event-broker/event-broker-draft-service/integration-example-using-cap-application?state=DRAFT) to prepare your SAP BTP account for event consumption.
Follow guide _SAP Event Broker Service Guide_ → _Integration Scenarios_ → [CAP Application as a Subscriber](https://help.sap.com/docs/event-broker/event-broker-draft-service/integration-example-using-cap-application) to prepare your SAP BTP account for event consumption.

@renejeglinsky @smahati we need to replace with a link to a published doc before releasing

#### 2. Decoupled

In the second option, you define the event manually in any service, but link it to the respective cloud event type via `@topic`.

Copy link
Contributor

@David-Kunz David-Kunz Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Event Broker enforces the [cloudevents](https://cloudevents.io/) standard and `@topic` refers to the cloudevents `type` property.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event manually in any service

Not true, it must be in an external service. Otherwise it's considered to be an event the app publishes.

Add an _Integration Dependency_ using the _Simplified Business Eventing Template_ for _Event Type_ `sap.eee.iwxbe.testproducer.v1.Event.Created.v1` and _Publishing System Namespace_ `sap.s4` as shown in the following screenshot.

![Integration Dependency for Test Event](assets/event-broker-test-integraion-dependency.png)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2. Create Formation

missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, formation will already exist (event broker docs)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formation needs to be manually created

[Learn more about `cds.env` profiles](../../node.js/cds-env#profiles){.learn-more}

::: tip Local Testing
Since SAP Event Broker sends events via HTTP, local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment so that we don't miss the incomplete sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't help 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjvans Will you complete the sentence? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjvans Will you complete the sentence? :)

i don't know what @David-Kunz wanted to say here ;) but yes, we'll take care of it

@renejeglinsky renejeglinsky merged commit 12d2f43 into main Sep 25, 2024
3 of 4 checks passed
@renejeglinsky renejeglinsky deleted the event-broker-cap branch September 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants