Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the default behaviour of the messaging error handler #1369

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dimamost
Copy link
Contributor

No description provided.

@@ -679,6 +679,44 @@ private void handleError(MessagingErrorEventContext ctx) {
ctx.setResult(true); // acknowledge
}
}
```

In the multitenant application, there may be scenarios in which the client is not yet or no longer available. In this case, the message cannot be processed for the client because the client context is not available. In this case, the standard error handler acknowledges the message to prevent it from getting stuck in the message sequence. To change this behavior, the custom error handler from the example above can be extended by checking the exception type of the unknown tenant.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should rather name the problem with subscriptions/races etc. here. Otherwise it's not clear for customers what it is actually about. The error message also explicitly refers to the tenant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants