Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(databases): Really fix code comment in SQL snippet #975

Merged
merged 2 commits into from
Jun 5, 2024
Merged

fix(databases): Really fix code comment in SQL snippet #975

merged 2 commits into from
Jun 5, 2024
+1 −1

Conversation

bugwelle
Copy link
Contributor

@bugwelle bugwelle commented Jun 5, 2024

Follow up to #972.

@bugwelle bugwelle requested a review from swaldmann June 5, 2024 06:15
@swaldmann
Copy link
Contributor

This will render the -- though, which is quite weird. So I'd either add an actual comment or use the line highlighting instead.

bugwelle
bugwelle commented Jun 5, 2024
View reviewed changes
guides/databases.md Outdated Show resolved Hide resolved
@renejeglinsky renejeglinsky merged commit abd42dd into main Jun 5, 2024
4 checks passed
@renejeglinsky renejeglinsky deleted the bugwelle-patch-1 branch June 5, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renejeglinsky renejeglinsky renejeglinsky approved these changes

@swaldmann swaldmann swaldmann approved these changes

@smahati smahati Awaiting requested review from smahati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugwelle @swaldmann @renejeglinsky