review fix

cap-js · Jan 8, 2024 · b7ff8b3 · b7ff8b3
1 parent 8f096ec
commit b7ff8b3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/lib/resolvers/parse/ast2cqn/where.js b/lib/resolvers/parse/ast2cqn/where.js
@@ -32,9 +32,13 @@ const _objectFieldTo_xpr = (objectField, columnName) => {
   const ref = { ref: [columnName] }
   const gqlOperator = objectField.name.value
 
-if (gqlOperator === 'in') { 
-    return [ref, _gqlOperatorToCdsOperator(gqlOperator),  { list: objectField.value.values.map(value => ({ val: value.value })) }]
-  } 
+  if (gqlOperator === 'in') {
+    return [
+      ref,
+      _gqlOperatorToCdsOperator(gqlOperator),
+      { list: objectField.value.values.map(value => ({ val: value.value })) }
+    ]
+  }
   if (objectField.value.kind === Kind.LIST) {
     const _xprs = objectField.value.values.map(value => _to_xpr(ref, gqlOperator, value.value))
     return _joinedXprFrom_xprs(_xprs, 'and')

diff --git a/test/schemas/edge-cases/fields-with-connection-names.gql b/test/schemas/edge-cases/fields-with-connection-names.gql
@@ -95,6 +95,7 @@ input ID_filter {
   eq: ID
   ge: ID
   gt: ID
+  in: [ID]
   le: ID
   lt: ID
   ne: [ID]
@@ -119,6 +120,7 @@ input String_filter {
   eq: String
   ge: String
   gt: String
+  in: [String]
   le: String
   lt: String
   ne: [String]

diff --git a/test/tests/queries/filter.test.js b/test/tests/queries/filter.test.js
@@ -386,7 +386,7 @@ describe('graphql - filter', () => {
         const query = gql`
           {
             AdminService {
-              Books(filter: [{ ID: { in: [201, 251] }},  { title: { contains: "cat" } }]) {
+              Books(filter: [{ ID: { in: [201, 251] } }, { title: { contains: "cat" } }]) {
                 nodes {
                   ID
                   title