nested limits work with @cap-js/sqlite

cap-js · Feb 23, 2024 · f74062f · f74062f
1 parent 689b0a8
commit f74062f
Show file tree

Hide file tree

Showing 2 changed files with 68 additions and 34 deletions.
diff --git a/test/tests/queries/paging-offset.test.js b/test/tests/queries/paging-offset.test.js
@@ -61,19 +61,27 @@ describe('graphql - offset-based paging', () => {
         }
       `
       const data = {
-        AdminServiceBasic: {
-          Authors: null
+        AdminService: {
+          Authors: [
+            {
+              name: 'Edgar Allen Poe',
+              books: [
+                // Edgar Allen Poe has 2 books, but only 1 requested.
+                {
+                  title: 'Eleonora'
+                }
+              ]
+            },
+            {
+              name: 'Richard Carpenter',
+              books: []
+            }
+          ]
         }
       }
-      const errors = [
-        {
-          locations: [{ column: 13, line: 4 }],
-          message: 'Pagination is not supported in expand',
-          path: ['AdminServiceBasic', 'Authors']
-        }
-      ]
+
       const response = await POST('/graphql', { query })
-      expect(response.data).toEqual({ data, errors })
+      expect(response.data).toEqual({ data })
     })
   })
 
@@ -120,8 +128,7 @@ describe('graphql - offset-based paging', () => {
       expect(response.data).toEqual({ data })
     })
 
-    // @cap-js/sqlite does not throw that error
-    test.skip('query with top and skip arguments on nested fields', async () => {
+    test('query with top and skip arguments on nested fields', async () => {
       const query = gql`
         {
           AdminService {
@@ -140,19 +147,32 @@ describe('graphql - offset-based paging', () => {
       `
       const data = {
         AdminService: {
-          Authors: null
+          Authors: {
+            nodes: [
+              {
+                name: 'Edgar Allen Poe',
+                books: {
+                  // Edgar Allen Poe has 2 books, but only 1 requested.
+                  nodes: [
+                    {
+                      title: 'Eleonora'
+                    }
+                  ]
+                }
+              },
+              {
+                name: 'Richard Carpenter',
+                books: {
+                  nodes: []
+                }
+              }
+            ]
+          }
         }
       }
-      const errors = [
-        {
-          locations: [{ column: 13, line: 4 }],
-          message: 'Pagination is not supported in expand',
-          path: ['AdminService', 'Authors'],
-          extensions: expect.any(Object)
-        }
-      ]
+
       const response = await POST('/graphql', { query })
-      expect(response.data).toEqual({ data, errors })
+      expect(response.data).toEqual({ data })
     })
   })
 })
diff --git a/test/tests/queries/totalCount.test.js b/test/tests/queries/totalCount.test.js
@@ -139,8 +139,7 @@ describe('graphql - queries with totalCount', () => {
     expect(response.data).toEqual({ data })
   })
 
-  // @cap-js/sqlite does not throw that error
-  test.skip('query with totalCount and top and skip arguments on nested fields', async () => {
+  test('query with totalCount and top and skip arguments on nested fields', async () => {
     const query = gql`
       {
         AdminService {
@@ -161,19 +160,34 @@ describe('graphql - queries with totalCount', () => {
     `
     const data = {
       AdminService: {
-        Authors: null
+        Authors: {
+          totalCount: 4,
+          nodes: [
+            {
+              name: 'Edgar Allen Poe',
+              books: {
+                totalCount: null, // REVISIT: expected 2
+                nodes: [
+                  {
+                    title: 'Eleonora'
+                  }
+                ]
+              }
+            },
+            {
+              name: 'Richard Carpenter',
+              books: {
+                totalCount: null, // REVISIT: expected 0
+                nodes: []
+              }
+            }
+          ]
+        }
       }
     }
-    const errors = [
-      {
-        locations: [{ column: 11, line: 4 }],
-        message: 'Pagination is not supported in expand',
-        path: ['AdminService', 'Authors'],
-        extensions: expect.any(Object)
-      }
-    ]
+
     const response = await POST('/graphql', { query })
-    expect(response.data).toEqual({ data, errors })
+    expect(response.data).toEqual({ data })
   })
 
   test('query with aliases on totalCount on nested fields', async () => {