Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for no Security Schema #47

Merged
merged 4 commits into from
Oct 17, 2024
+5 −0
Merged

Warning for no Security Schema #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69f697a
Update csdl2openapi.js
RoshniNaveenaS Oct 8, 2024
12ad621
Update CHANGELOG.md
RoshniNaveenaS Oct 8, 2024
bd59e31
Update CHANGELOG.md
RoshniNaveenaS Oct 17, 2024
ec5c4d9
Merge branch 'main' into securitySchemaWarning
RoshniNaveenaS Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
### Added

- OpenAPI documents can now have `externalDocs` object provided through `@OpenAPI.externalDocs` annotation in the service level of CDS.
- OpenAPI documents now throws warning if `securitySchemas` are not found.

## Version 1.0.6 - 23.09.2024

Expand Down
4 changes: 4 additions & 0 deletions lib/compile/csdl2openapi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2432,6 +2432,10 @@ see [Expand](http://docs.oasis-open.org/odata/odata/v4.01/odata-v4.01-part1-prot
*/
function security(openapi, entityContainer) {
const securitySchemes = entityContainer && entityContainer[voc.Authorization.SecuritySchemes] ? entityContainer[voc.Authorization.SecuritySchemes] : [];
// check if securitySchemas exist if it does not exist then throw a warning
if (securitySchemes.length === 0) {
console.warn('No security schemes defined in the entity container');
}
if (securitySchemes.length > 0) openapi.security = [];
securitySchemes.forEach(scheme => {
const s = {};
Expand Down