Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved default texts #48

Conversation

ralfhandl
Copy link
Contributor

for

  • info.title
  • info.description
  • x-sap-shortText

Copy link
Collaborator

@RoshniNaveenaS RoshniNaveenaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@RoshniNaveenaS RoshniNaveenaS merged commit 7de0ae1 into cap-js:main Oct 14, 2024
4 checks passed
@chgeo
Copy link
Member

chgeo commented Oct 21, 2024

Heads-up: These changed texts might have broken tests like this one here: https://github.com/chgeo/cds-swagger-ui-express/actions/runs/11439500626/job/31823298360

@RoshniNaveenaS such changes should not be released in a patch like 1.0.7, but deserve a minor version like 1.1.0
Also, this change is not mentioned at all in the changelog. I suggest to mention it there, with a note that this could be breaking for tests.

@ralfhandl ralfhandl deleted the Rules-and-defaults-for-title,-description,-shortText branch October 30, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants