Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI: Revert changes from PR #42 #57

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

RoshniNaveenaS
Copy link
Collaborator

@RoshniNaveenaS RoshniNaveenaS commented Dec 3, 2024

As per the discussion for the issue , reverting the change of appending the protocol and serviceName.

The URLs provided via command line options --openapi:url or --openapi:servers should be taken literally without appending protocol and service name.

These URLs tell where the service is deployed, and CAP should not make any assumptions on the deployment URL, nor impose any path conventions on how applications want to deploy their CAP microservice.

If none of these command line options is provided, the default URL of course needs to match the default URL of the CAP runtime, which now includes protocol and service name.

@RoshniNaveenaS RoshniNaveenaS merged commit f3fcc81 into main Dec 3, 2024
4 checks passed
@RoshniNaveenaS RoshniNaveenaS deleted the revertMultipleServer branch December 3, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants