Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add editor changes #67

Merged
merged 3 commits into from
Aug 30, 2024
Merged

chore: Add editor changes #67

merged 3 commits into from
Aug 30, 2024

Conversation

jcesarmobile
Copy link
Contributor

This PR introduced some vscode automatic formatting.

This PR just saves the files so the editor re arranges imports and add missing ending lines.

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robingenz
Copy link
Member

It seems that the formatting is not correct now (see https://github.com/capacitor-community/photoviewer/actions/runs/10631116351/job/29471356650?pr=67). Possibly only whitespaces. Please try to run npm run fmt.

@jcesarmobile
Copy link
Contributor Author

fmt fixes the lint problem, but saving the file reintroduces the lint problem, so looks like it's not working as expected?

@jcesarmobile
Copy link
Contributor Author

If there is no new line it adds it, but if there is one it still adds another one, only happens on the index.ts file.

@robingenz robingenz merged commit 4238a82 into main Aug 30, 2024
2 checks passed
@jcesarmobile jcesarmobile deleted the editor-changes branch August 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants