Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Snowflake Dataframe Naming #382

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Update Snowflake Dataframe Naming #382

merged 4 commits into from
Feb 21, 2025

Conversation

rhaffar
Copy link
Contributor

@rhaffar rhaffar commented Feb 18, 2025

In order to allow for comparisons with similarly named tables across different schemas/dbs, the default naming convention for Snowpark DFs from Snowflake Tables has been updated.

Closes #381

Snowflake tests passing locally

Copy link
Member

@fdosani fdosani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wondering if we want to add some tests too?

@rhaffar
Copy link
Contributor Author

rhaffar commented Feb 18, 2025

LGTM, wondering if we want to add some tests too?

Yeah I though of this but wanted to avoiding having to hardcode a separate db/schema, one of the quirks of SF testing. I can make additional environment variables and use those instead.

@rhaffar rhaffar merged commit 134da69 into develop Feb 21, 2025
39 checks passed
@fdosani fdosani mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Snowpark/Snowflake comparison of tables named the same, but in different schemas doesn't work
2 participants