intersection of rows as the datasets have no mutual key/connection #385
+366
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdosani
requested review from
ak-gupta,
jdawang,
gladysteh99 and
rhaffar
as code owners
rhaffar
reviewed
Feb 27, 2025
| @@ -561,6 +593,15 @@ def all_mismatch(self, ignore_matching_cols: bool = False) -> "pl.DataFrame": | |||
| LOG.debug( | |||
| f"Column {orig_col_name} is equal in df1 and df2. It will not be added to the result." | |||
| ) | |||
| if len(match_list) == 0: | |||
There was a problem hiding this comment.
Are we ok returning mismatches based on unique rows when this condition is triggered via all match columns being equal and ignore_matching_cols being set to True?
There was a problem hiding this comment.
I think it is fine. In this situation we are deviating from the normal workflow. This corner cases is more of when we are dealing with the join columns, so by definition it will be a "composite key" of all the join columns. So in this case I think it is fine. Would be interested in your thoughts or insights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR are for Pandas and Polars only.
only_join_columnswhich indicates if all the columns are join columns. This is a specific corner case which prompted this PR._intersect_comparemetrics (row_cnt,match_cnt)whereonly_join_columnscorner case is present.intersect_rows_matchshould returnFalseif the DataFrame is empty.sample_mismatchneeds to account for the corner case situation rather than look forcolumn + "_match"all_mismatchneeds to account for the corner case situation rather than look forcolumn + "_match"@rhaffar I've made a couple of more tweaks after hitting some bugs here and there from the last time you checked. Would appreciate another set of eyes here.
I'm hoping this covers all the weird corner cases where: