Skip to content

Commit

Permalink
remove prefect dependency (#485)
Browse files Browse the repository at this point in the history
* remove prefect dependency
* fix error text in test
  • Loading branch information
ryanSoley authored Sep 23, 2024
1 parent 5054eb1 commit cfc90ab
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
2 changes: 1 addition & 1 deletion rubicon_ml/workflow/prefect/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ def _check_for_prefect_extras():
try:
import prefect # noqa F401
except ImportError:
install_command = "pip install rubicon[prefect]"
install_command = "pip install prefect<=2.20.3,>=2.16.5"
message = f"Install `prefect` with `{install_command}`."

raise ImportError(message)
Expand Down
6 changes: 0 additions & 6 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ install_requires =
scikit-learn<=1.5.1,>=0.22.0

[options.extras_require]
prefect =
backports.strenum<=1.3.1,>=1.3.1; python_version < "3.11"
prefect<=2.20.3,>=2.16.5
s3 =
s3fs<=2024.6.1,>=0.4
ui =
Expand All @@ -53,7 +50,6 @@ viz =
all =
dash<=2.17.1,>=2.11.0
dash-bootstrap-components<=1.6.0,>=1.0.0
prefect<=2.20.3,>=2.16.5
s3fs<=2024.6.1,>=0.4

[options.entry_points]
Expand Down Expand Up @@ -118,7 +114,6 @@ deps =
polars
pytest
pytest-cov
prefect
xgboost
extras =
all
Expand All @@ -131,7 +126,6 @@ upgrade =
jsonpath-ng
numpy
pandas
prefect
pyarrow
PyYAML
s3fs
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/workflow/prefect/test_prefect.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def test_deprecations():


def test_missing_prefect_extra_raises_error():
install_prefect_message = "Install `prefect` with `pip install rubicon[prefect]`."
install_prefect_message = "Install `prefect` with `pip install prefect<=2.20.3,>=2.16.5`."

with patch.dict(sys.modules, {"prefect": None}):
with pytest.raises(ImportError) as e:
Expand Down

0 comments on commit cfc90ab

Please sign in to comment.