Add XGBoost JSON Reader/writer #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a rebase should handle the test failures now |
ryanSoley
approved these changes
Jul 16, 2024
| ) -> Artifact: | ||
| """Log an XGBoost model as a JSON file to this client object. | ||
|
|
||
| Please note that we do not currently support logging directly from the SKLearn interface. |
There was a problem hiding this comment.
If users use the XGBRegressor or XGBClassifier classes that implement sklearn interface for xgboost this will not work. They would have to use model.get_booster() first and log that. An obvious addition is to check for that ourselves and then call model.get_booster() if relevant.
I can add that in this PR if you want.
There was a problem hiding this comment.
ahh gotcha, nah this is fine for now
|
closing and re-opening to try to get the license check to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #458
What
How to Test