Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guard viz import and fix prefect dependency #463

Merged
merged 7 commits into from
Jul 16, 2024
Merged

guard viz import and fix prefect dependency #463

merged 7 commits into from
Jul 16, 2024

Conversation

ryanSoley
Copy link
Member

@ryanSoley ryanSoley commented Jul 15, 2024 •
edited
Loading

What

  • guards the ExperimentsTable import in viz.py so a simple import rubicon_ml does not require additional dependencies
  • fixes prefect import - dependency backports.strenum no longer included with prefect for some reason
    • installs it via pip in conda envs as I can't figure out how to get them to respect the python version qualifier

How to Test

  • pip install rubicon-ml in a new environment
  • import rubicon_ml and validate there are no errors

@ryanSoley ryanSoley requested review from a team as code owners July 15, 2024 14:46
@ryanSoley ryanSoley self-assigned this Jul 15, 2024
@ryanSoley ryanSoley added the bugfix PRs that address the bugs detailed in 'bug' issues. label Jul 15, 2024
@ryanSoley ryanSoley changed the title guard viz import guard viz import and fix prefect dependency Jul 15, 2024
@ryanSoley ryanSoley merged commit cc3f5c1 into main Jul 16, 2024
7 checks passed
@ryanSoley ryanSoley deleted the viz-import-scoping branch July 16, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenpardy stephenpardy stephenpardy approved these changes

Assignees

@ryanSoley ryanSoley

Labels
bugfix PRs that address the bugs detailed in 'bug' issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanSoley @stephenpardy