metric correlation plot intake source added #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ryanSoley
approved these changes
Jul 18, 2024
This was referenced Jul 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #455
Description
Issue: Currently we are trying to build an extension for serving visualizations through a Juptyer lab extension. To do this we want to include visualization information in the catalogs. Initially, we created a base visualization data source similar to the existing one for projects and experiments. Now we need to create a concrete implementation for Metric Correlation Plot.
base.py
Solution: For this issue, we added a new MetricCorrelationPlotDataSource that is going to extend VizDataSourceMixin. We will read in the catalog data and metadata from the passed arguments . Then _get_schema creates a metric correlation plot visualization and sets it as the visualization object attribute.
Changes
Modified file viz.py within the intake_rubicon folder. This file holds the code for the new MetricCorrelationPlotDataSource.
Updated the init function within the intake_rubicon folder to now be able to include MetricCorrelationPlotDataSource for module importing purposes.
Updated the setup.cfg file to include the MetricCorrelationPlotDataSource as an Intake driver.