Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning and publishing workflow #9

Merged
merged 2 commits into from
Feb 24, 2021
Merged

versioning and publishing workflow #9

merged 2 commits into from
Feb 24, 2021

Conversation

dianelee217
Copy link
Contributor

What

  • Added CI/CD workflow for publishing package to pypi
  • Updated versioning
  • Added project classifiers

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
All committers have signed the CLA.

setup.py Show resolved Hide resolved
@mmccarty
Copy link

mmccarty commented Feb 24, 2021

Can you also add badges with CI status to the README?

See comment for example.

MINOR = 1
MICRO = 0

VERSION = '%d.%d.%d' % (MAJOR, MINOR, MICRO)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmccarty - we suggested starting at v0.1.0 - do you agree ?

# 3 - Alpha
# 4 - Beta
# 5 - Production/Stable
'Development Status :: 4 - Beta',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmccarty - we were debating between Beta, or Production/Stable -- what do you think?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Beta is fine for now given that we are just now open sourcing and might get some activity that would make things less stable.

add contributor

readme button

removing badge temporarily

lowercase
Copy link
Contributor

@joe-wolfe21 joe-wolfe21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dianelee217 dianelee217 merged commit 96fe107 into main Feb 24, 2021
@dianelee217 dianelee217 deleted the cicd branch February 24, 2021 20:10
@dianelee217 dianelee217 self-assigned this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants