-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capnpc: add option to build capnp
exe from src
#268
Open
rileylyman
wants to merge
1
commit into
capnproto:master
Choose a base branch
from
rileylyman:riley/capnpc-build-src
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "capnpc/capnproto"] | ||
path = capnpc/capnproto | ||
url = https://github.com/capnproto/capnproto.git |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
#[cfg(feature = "build-capnp")] | ||
fn main() { | ||
cmake::build("capnproto"); | ||
} | ||
|
||
#[cfg(not(feature = "build-capnp"))] | ||
fn main() { | ||
if !which::which("capnp").is_ok() { | ||
panic!( | ||
"capnp executable not found. install it with your package manager or enable the \ | ||
\"build-capnp\" feature to build it from source" | ||
); | ||
} | ||
Comment on lines
+8
to
+13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if !which::which("capnp").is_ok() {
panic!(msg);
} could be written as: which::which("capnp").expect(msg); |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,6 +66,19 @@ mod pointer_constants; | |
|
||
use std::path::{Path, PathBuf}; | ||
|
||
#[cfg(feature = "build-capnp")] | ||
fn capnp_exe() -> PathBuf { | ||
let mut p = PathBuf::from(env!("OUT_DIR")); | ||
p.push("bin"); | ||
p.push("capnp"); | ||
p | ||
Comment on lines
+71
to
+74
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably a matter of style, but you could just use: PathBuf::from(env!("OUT_DIR"))
.join("bin")
.join("capnp") |
||
} | ||
|
||
#[cfg(not(feature = "build-capnp"))] | ||
fn capnp_exe() -> PathBuf { | ||
PathBuf::from("capnp") | ||
} | ||
|
||
// Copied from capnp/src/lib.rs, where this conversion lives behind the "std" feature flag, | ||
// which we don't want to depend on here. | ||
pub(crate) fn convert_io_err(err: std::io::Error) -> capnp::Error { | ||
|
@@ -218,7 +231,7 @@ impl CompilerCommand { | |
let mut command = if let Some(executable) = &self.executable_path { | ||
::std::process::Command::new(executable) | ||
} else { | ||
::std::process::Command::new("capnp") | ||
::std::process::Command::new(&capnp_exe()) | ||
}; | ||
|
||
command.arg("compile").arg("-o").arg("-"); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake
should probably be marked optional, while activated bybuild-capnp
feature?See also Cargo reference. The
dep:
syntax requires Rust 1.60.