capnp-futures: Use more fine-grained futures-* deps #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The large futures crate pulls in a bunch of sub-crates that capnp-futures does not need. We can instead use only the subcrates that are actually required. Signed-off-by: Jens Reidel <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
==========================================
+ Coverage 51.64% 52.39% +0.74%
==========================================
Files 69 70 +1
Lines 33735 34570 +835
==========================================
+ Hits 17422 18112 +690
- Misses 16313 16458 +145 ☔ View full report in Codecov by Sentry. |
|
Looks good to me! (#199 was a previous attempt at this.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The large futures crate pulls in a bunch of sub-crates that capnp-futures does not need. We can instead use only the subcrates that are actually required.